Conversation
icewind1991
requested review from
CarlSchwan,
leftybournes and
nfebe
and removed request for
a team
icewind1991
force-pushed
the
share-target-repair-no-providers-33
branch
from
e29ee35 to
d765ec6
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
share-target-repair-no-providers-33
branch
from
d765ec6 to
8916866
Compare
CarlSchwan
reviewed
Jan 30, 2026
| return (int)$query->executeQuery()->fetchOne(); | ||
| } | ||
|
|
||
| private function moveShare(string $id, string $target) { |
Member
There was a problem hiding this comment.
Suggested change
| private function moveShare(string $id, string $target) { | |
| private function moveShare(string $id, string $target): void { |
come-nc
reviewed
Feb 2, 2026
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Is that not skipping a bunch of events which would be sent when renaming the share?
Potentially breaking apps relying on those?
Signed-off-by: Robin Appelman <robin@icewind.nl>
Member
Author
There is currently no event for moving shares |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #57926